Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@atenjin
Copy link

@atenjin atenjin commented Jan 13, 2021

No description provided.

@bkchr bkchr merged commit 48558a2 into paritytech:rococo-v1 Jan 13, 2021
@JoshOrndorff
Copy link
Contributor

I'm curious about this PR because I've been struggling with dependencies lately. Would you mind sharing some knowledge?

  1. Is it necessary that Cumulus use the same version of log that Substrate does?
  2. If not necessary, is it desirable?
  3. Was this upgrade solving a specific problem?

@bkchr
Copy link
Member

bkchr commented Jan 13, 2021

  • Is it necessary that Cumulus use the same version of log that Substrate does?

No. This is only a patch version difference.

  • If not necessary, is it desirable?

Less dependencies to compile.

@atenjin atenjin deleted the rococo-v1 branch January 15, 2021 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants