Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@akru
Copy link
Contributor

@akru akru commented Jan 24, 2021

Question

Are HRMP messages should be tagged as routed from the relay chain for the XCM executor, didn't they?

@bkchr bkchr requested a review from shawntabrizi January 25, 2021 13:23
@shawntabrizi
Copy link
Member

@akru as far as I understand, horizontal messages are directly from Parachain to Parachain, so this change does not make sense to me.

@pepyakin
Copy link
Contributor

Right

@pepyakin pepyakin closed this Jan 25, 2021
@akru
Copy link
Contributor Author

akru commented Jan 25, 2021

@shawntabrizi probably, you didn’t write XCM executor. With your position is difficult to explain this naming https://github.com/paritytech/polkadot/blob/master/xcm/xcm-builder/src/location_conversion.rs#L92

So, let’s make it clear. HRMP message routing is parachain-to-parachain, as you said, right? Routing information about location should be removed, but in fact hrmp routes message, it’s not direct way, right?

@shawntabrizi shawntabrizi reopened this Feb 5, 2021
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akru my apologies, I believe you were totally correct here.

An important note that I got from Gav was that the multilocation is completely unaffected by the messaging/delivery system. This was a fundamental misunderstanding that I had.

As such, when you have Parachain A and Parachain B connected to a Parent Relay Chain, the multi location in the eyes of Parachain B will always be Location(Parent, Parachain A).

@bkchr bkchr merged commit bd3697d into paritytech:rococo-v1 Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants