This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Introduce CollectCollationInfo runtime api
#443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using well known keys to communicate information about a collation between the runtime and the collator, we now use a runtime api for this.
pepyakin
approved these changes
May 17, 2021
Contributor
pepyakin
left a comment
pepyakin
left a comment
There was a problem hiding this comment.
Looks good. I really love this change.
A couple of nits and typos.
| sp_api::decl_runtime_apis! { | ||
| /// Runtime api to collect information about a collation. | ||
| pub trait CollectCollationInfo { | ||
| /// Collect information about a collation. |
Contributor
There was a problem hiding this comment.
Can we write a proper docs on this? I.e. what's is expected from the implementer? When this is supposed to be called? etc
Can push to a follow up as well
| ValidationResult { | ||
| head_data, | ||
| new_validation_code, | ||
| new_validation_code: new_validation_code.map(Into::into), |
Contributor
There was a problem hiding this comment.
What's are the types that particupate in this conversion? Is it convenient to switch to Type::from here?
pallets/parachain-system/src/lib.rs
Outdated
|
|
||
| /// New validation code that was set in a block. | ||
| /// | ||
| /// This will be cleared in `on_initialize` of each new block. |
Contributor
There was a problem hiding this comment.
It's not so simple here due to the DidSetValidationCode check.
Co-authored-by: Sergei Shulepov <[email protected]>
bkchr
added a commit
that referenced
this pull request
May 17, 2021
* Introduce `CollectCollationInfo` runtime api Instead of using well known keys to communicate information about a collation between the runtime and the collator, we now use a runtime api for this. * Fixes bug * Apply suggestions from code review Co-authored-by: Sergei Shulepov <[email protected]> * Doc update Co-authored-by: Sergei Shulepov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using well known keys to communicate information about a
collation between the runtime and the collator, we now use a runtime api
for this.
Fixes: #344