Update CLI #53
Update CLI #53
Conversation
Forked at: 0efd15c Parent branch: master
| } | ||
|
|
||
| fn run_command_and_kill(signal: Signal) { | ||
| let mut cmd = Command::new(cargo_bin("cumulus-test-parachain-collator")).spawn().unwrap(); |
There was a problem hiding this comment.
Please make sure that you delete the interrupt_test dir before running the command.
| ) -> sc_cli::error::Result<()> { | ||
| let para_id = crate::PARA_ID; | ||
|
|
||
| if polkadot_config.expect_chain_spec().is_kusama() { |
There was a problem hiding this comment.
No, this check should not be here. This needs to be done in Polkadot!
There was a problem hiding this comment.
I'm working on this but it is complicated because the services can be full or light and the signature is different, etc...
MEANWHILE: this was intended 😁 I know you don't like it but the code is also on polkadot and doesn't change. The only reason I duplicate it here is to be able to clone the task_executor upon launch.
There was a problem hiding this comment.
I know that we have the same code in Polkadot, but that is already some generic nightmare there. Downstream should not be required to do the same :)
There was a problem hiding this comment.
I made the issue #56 to not lose track of this
Co-Authored-By: Bastian Köcher <[email protected]>
* [docs] update downward-token-tx.png * [docs] update docs with xcm-version config.
Fixes #24
Default ports for polkadot chain.