Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

polkadot collator builder #740

Merged
TriplEight merged 2 commits into from
Nov 11, 2021
Merged

polkadot collator builder #740

TriplEight merged 2 commits into from
Nov 11, 2021

Conversation

@TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Nov 10, 2021

  • add polkadot-collator_builder.Containerfile to simplify/unify the build process for the users and docs on how to use it
  • not quite sure if you use docker/test-parachain-collator.dockerfile but I've optimized it a bit.

@TriplEight TriplEight requested review from alvicsam and bkchr November 10, 2021 11:18
@TriplEight TriplEight self-assigned this Nov 10, 2021
@alvicsam
Copy link
Contributor

alvicsam commented Nov 10, 2021

Why polkadot-collator_builder.Containerfile not polkadot-collator_builder.Dockerfile?

@TriplEight
Copy link
Contributor Author

TriplEight commented Nov 10, 2021

The syntax is the same, docker consumes both extensions likewise, as well as podman and buildah. We use the latter ones. Just want to quit this Xerox thing, nothing more than that.

@alvicsam
Copy link
Contributor

alvicsam commented Nov 10, 2021

The syntax is the same, docker consumes both extensions likewise, as well as podman and buildah. We use the latter ones. Just want to quit this Xerox thing, nothing more than that.

I think it worth adding to the container naming policy

@TriplEight TriplEight merged commit 7100363 into master Nov 11, 2021
@TriplEight TriplEight deleted the 3x8_polkadot-collator_builder branch November 11, 2021 12:57
@TriplEight TriplEight mentioned this pull request Nov 11, 2021
Closed
ordian pushed a commit that referenced this pull request Nov 11, 2021
Merge branch 'master' into sandreim/task_group_name
6b1b936 
* master:
  polkadot collator builder (#740)
  Port transaction pool benchmark (#738)
  Update to latest substrate and polkadot dependencies (#745)
@github-actions github-actions bot mentioned this pull request Dec 2, 2021
Closed
@ghzlatarev ghzlatarev mentioned this pull request Dec 4, 2021
Merged
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bkchr bkchr bkchr approved these changes

@alvicsam alvicsam alvicsam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TriplEight TriplEight

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TriplEight @alvicsam @bkchr