This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update to latest Polkadot & Substrate #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
reviewed
Apr 6, 2020
| sc-network = { git = "https://github.com/paritytech/substrate", branch = "cumulus-branch" } | ||
| sc-client = { git = "https://github.com/paritytech/substrate", branch = "cumulus-branch" } | ||
| sc-basic-authorship = { git = "https://github.com/paritytech/substrate", branch = "cumulus-branch" } | ||
| sc-basic-authorship = { git = "https://github.com/paritytech/substrate", branch = "cumulus-branch", version = "0.8.0-alpha.5" } |
Contributor
There was a problem hiding this comment.
This looks fishy. Is it intended??
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .with_wasm_builder_from_crates("1.0.9") | ||
| .with_wasm_builder_from_git("https://github.com/paritytech/substrate.git", "0b30207969fdde85e0dad785750757399cd0e3e4") |
Contributor
There was a problem hiding this comment.
There is no branch or tag we can use instead? Like cumulus-branch for instance?
Contributor
There was a problem hiding this comment.
And why didn't you pin to the branch instead? You needed that commit in particular? It wouldn't have work on cumulus-branch?
| WasmBuilder::new() | ||
| .with_current_project() | ||
| .with_wasm_builder_from_crates("1.0.9") | ||
| .with_wasm_builder_from_git("https://github.com/paritytech/substrate.git", "0b30207969fdde85e0dad785750757399cd0e3e4") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.