Skip to content

Add a subscription manager #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomusdrw merged 16 commits into from
May 27, 2020
Merged

Add a subscription manager #548

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7ef90a3
WIP: Add a subscription manager.
HCastano May 19, 2020
9883720
Allow IdProvider::Id and SubscriptionId to work together
HCastano May 21, 2020
a41638e
Update SubscriptionId tests
HCastano May 21, 2020
05b1a92
Rustfmt
HCastano May 21, 2020
0149fd4
Use `SubscriptionId` as the key for `active_subscriptions`
HCastano May 21, 2020
f0fabd9
Add subscription ID providers.
HCastano May 21, 2020
c89511d
Add some documentation
HCastano May 21, 2020
cd31378
Clean up comment and naming
HCastano May 22, 2020
3cf3113
Change the NumericIdProvider to use `u64` IDs
HCastano May 22, 2020
7e435a0
Add tests for IdProvider and SubscriptionManager
HCastano May 25, 2020
1e5846f
Restore RandomStringIdProvider as the default provider
HCastano May 26, 2020
1334760
Retain receiver.:
tomusdrw May 27, 2020
476edee
Make test executor a lazy static
HCastano May 27, 2020
c3dafbc
Rustfmt
HCastano May 27, 2020
52caa9a
Add a comment to test
HCastano May 27, 2020
2c27a2d
Remove `matches!` macro
HCastano May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up comment and naming
  • Loading branch information
@HCastano
HCastano committed May 22, 2020
commit cd31378481e73dfcabcf94a1ffc9121f23bace97
4 changes: 2 additions & 2 deletions pubsub/src/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,12 @@ impl Default for RandomStringIdProvider {
pub struct SubscriptionManager<I: IdProvider = RandomStringIdProvider> {
id_provider: I,
active_subscriptions: ActiveSubscriptions,
executor: TaskExecutor, // Make generic?
executor: TaskExecutor,
}

impl<I: IdProvider> SubscriptionManager<I> {
/// Creates a new SubscriptionManager.
pub fn new_with_id_provider(id_provider: I, executor: TaskExecutor) -> Self {
pub fn with_id_provider(id_provider: I, executor: TaskExecutor) -> Self {
Self {
id_provider,
active_subscriptions: Default::default(),
Expand Down