Migrate core to futures=0.3 #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Jul 23, 2020
Contributor
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
Braver than me tackling this beast. Looks good, only a few insubstantial comments.
Contributor
Author
|
@ascjones I believe I've addressed all of your comments now, would you mind taking another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards #485 (also see #422). The PR rewrites
jsonrpc-core&jsonrpc-derive&jsonrpc-core-client(but not transports) to be compatible withfutures=0.3.jsonrpc-deriveis limited to return eitherResult<_>orBoxFuture<Result<_>>(seeWrapFuturetrait), supporting custom future types would require a bit more work. Actually it would be best to check out if we can integrate it withasync_trait, so that the implementations can simply defineasyncfunctions.The transports (servers) currently run the futures in
compatmode, they should be updated as well.