Skip to content

Make sure manager is Sync+Send #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomusdrw merged 1 commit into from
Jul 30, 2020
Merged

Make sure manager is Sync+Send #573

tomusdrw merged 1 commit into from
Jul 30, 2020

Conversation

@tomusdrw
Copy link
Contributor

@tomusdrw tomusdrw commented Jul 29, 2020

No description provided.

ascjones
ascjones approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomusdrw tomusdrw merged commit 8e7ddc9 into master Jul 30, 2020
@tomusdrw tomusdrw deleted the td-pubsub-manager branch July 30, 2020 09:27
@tomusdrw
Copy link
Contributor Author

tomusdrw commented Jul 30, 2020

This prevents using LocalSpawner, but in practice it wouldn't work anyway, because jsonrpc-derive trait implementations enforce Send + Sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ascjones ascjones ascjones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomusdrw @ascjones