Return error when unsubscribing from invalid subscription id #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
No problem, thanks for the quick review! Do you think this could get released today? I'd like to get the fix in asap, but can build off a fork if needed. Cheers! |
niklasad1
approved these changes
Mar 9, 2021
Contributor
Author
|
Hey @tomusdrw! Just a friendly ping about getting this out into a new release 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When processing a pubsub unsubscribe request, the unsubscribe callback is called even if there was no active subscription for that id.
Changes
cc @tomusdrw