Bubble up errors in broadcast_signal
#17
Conversation
Signed-off-by: Andrei Sandu <[email protected]>
| pub async fn broadcast_signal(&mut self, signal: #signal_ty) -> ::std::result::Result<(), #error_ty > { | ||
| #( | ||
| let _ = self. #subsystem_name .send_signal(signal.clone()).await; | ||
| self. #subsystem_name .send_signal(signal.clone()).await?; |
There was a problem hiding this comment.
One curious thing in Rust: _ is a non-binding association, so if the intention was to drop the result after the block it would not be hold...
There was a problem hiding this comment.
Hey @vstakhov , I don't quite get how that is related? The only reason it exists was to make the compiler 🤫 on the unused result.
There was a problem hiding this comment.
I am not sure what the intention was, I'd speculate this has gone through some refactoring and original reasoning cannot be recovered. Maybe @drahnr might know something
There was a problem hiding this comment.
This was part of the initial implementation, before it became a framework, before disputes existed, and when the base assumption was that the signal channels are almost always empty and "are not a problem".
3 participants
No description provided.