Skip to content
This repository was archived by the owner on Sep 13, 2021. It is now read-only.

Conversation

@Stefie
Copy link
Contributor

@Stefie Stefie commented Mar 31, 2020

Implements changes from paritytech/substrate#5103

I updated the raw Rust and AssemblyScript tests.

The Solang test is still failing, that means that an old version of Solang is pulled in somewhere.
Could you have a look at this @kirillt and fix it in a separate PR?

@seunlanlege merged the PR in Solang 5 days ago: hyperledger-solang/solang#141

@Stefie Stefie requested a review from TriplEight March 31, 2020 12:07
@seunlanlege
Copy link

😅, Looks like parallel universes have merged and I have a doppelganger running around merging PRs in hyperledger.

@seunlanlege
Copy link

oh wait you meant to tag @seanyoung

Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefie
Copy link
Contributor Author

Stefie commented Mar 31, 2020

oh wait you meant to tag @seanyoung

Exactly, damned, sorry @seunlanlege 😄 ! It seems I hit enter too fast, you were the first suggestion that popped up

@Stefie Stefie merged commit bf23eac into master Mar 31, 2020
@Stefie Stefie deleted the sd-updated-ext_set_storage branch March 31, 2020 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants