Bump Substrate to RC5 #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in v.1.6.0 which kept us locked to v1.5 releases. I think that's fixed now so I'm bumping this.
HCastano
added
A-deps
A-chores
tomusdrw
reviewed
Jul 29, 2020
bin/node/node/src/service.rs
Outdated
| use grandpa::{self, FinalityProofProvider as GrandpaFinalityProofProvider, SharedVoterState, StorageAndProofProvider}; | ||
| use sc_client_api::ExecutorProvider; | ||
| use sc_consensus::LongestChain; | ||
| use bridge_node_runtime::{self, Block, RuntimeApi}; |
Contributor
There was a problem hiding this comment.
Is it necessary for us to have that file at all? Isn't it possible to reference the service builder from substrate somehow?
Contributor
Author
There was a problem hiding this comment.
No, I don't think so
This comes from Substrate, so I'd rather just keep the code as is
Contributor
Author
|
Ah, I forgot about the benchmark changes. I'll fix those tomorrow-ish |
tomusdrw
approved these changes
Aug 3, 2020
| let (grandpa_block_import, grandpa_link) = | ||
| sc_finality_grandpa::block_import(client.clone(), &(client.clone() as Arc<_>), select_chain.clone())?; | ||
|
|
||
| let aura_block_import = |
Contributor
There was a problem hiding this comment.
I didn't notice that earlier, but we run with AuRa + Grandpa? That's pretty cool and hopefully works :)
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Bump Substrate to rc5 * Bump async-std to v1.6.2 There was a bug in v.1.6.0 which kept us locked to v1.5 releases. I think that's fixed now so I'm bumping this. * Update bridge node runtime * Update node service * Update CLI * Add SystemWeightInfo type to test runtimes * Add RPC extension builder to service * Directly return rpc_extensions_builder * Allow complex types in service This comes from Substrate, so I'd rather just keep the code as is * Update benchmarking code for new CLI
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Bump Substrate to rc5 * Bump async-std to v1.6.2 There was a bug in v.1.6.0 which kept us locked to v1.5 releases. I think that's fixed now so I'm bumping this. * Update bridge node runtime * Update node service * Update CLI * Add SystemWeightInfo type to test runtimes * Add RPC extension builder to service * Directly return rpc_extensions_builder * Allow complex types in service This comes from Substrate, so I'd rather just keep the code as is * Update benchmarking code for new CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured I'd end my day with something easy, but turns out that the changes in
service.rswere a bit hairy (introduced in paritytech/substrate#6557). I ended up copying the updatednode-templateinstead of digging through everything.Keeping it as a draft because I need to fix the RPC extensions in the service, and I want to double check I haven't accidentally screwed the node up.