Skip to content

Relay basic single-bit message dispatch results back to the source chain #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svyatonik merged 10 commits into from
Jun 21, 2021
Merged

Relay basic single-bit message dispatch results back to the source chain #935

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f7171f1
relay dispatch result flags back to the source chain
svyatonik Apr 27, 2021
61ec89e
OnMessagesDelivered callback
svyatonik Apr 28, 2021
2110b9a
add lane id to OnDeliveredMessages callback
svyatonik Apr 28, 2021
7377557
fix benchmarks && upate weights
svyatonik Jun 18, 2021
b43bc21
clippy
svyatonik Jun 18, 2021
71be9ed
clippy
svyatonik Jun 18, 2021
bd88510
clipy another try
svyatonik Jun 18, 2021
15b3acf
OnMessagesDelivered -> OnDeliveryConfirmed
svyatonik Jun 21, 2021
d231c82
Update primitives/messages/src/source_chain.rs
svyatonik Jun 21, 2021
858e170
Merge branch 'relay-basic-dispatch-results' of https://github.com/par…
svyatonik Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy
  • Loading branch information
@svyatonik
svyatonik committed Jun 18, 2021
commit b43bc214a1d4132448caa6a14e253017b3767a5e
12 changes: 6 additions & 6 deletions primitives/messages/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ impl DeliveredMessages {
/// Panics if message nonce is not in the `begin..=end` range. Typically you'll first
/// check if message is within the range by calling `contains_message`.
pub fn message_dispatch_result(&self, nonce: MessageNonce) -> bool {
const INVALID_NONCE: &'static str = "Invalid nonce used to index dispatch_results";
const INVALID_NONCE: &str = "Invalid nonce used to index dispatch_results";

let index = nonce.checked_sub(self.begin).expect(INVALID_NONCE) as usize;
*self.dispatch_results.get(index).expect(INVALID_NONCE)
Expand Down Expand Up @@ -373,11 +373,11 @@ mod tests {
dispatch_results: bitvec![Msb0, u8; 1; 151],
};

assert_eq!(delivered_messages.contains_message(99), false);
assert_eq!(delivered_messages.contains_message(100), true);
assert_eq!(delivered_messages.contains_message(150), true);
assert_eq!(delivered_messages.contains_message(151), false);
assert!(!delivered_messages.contains_message(99));
assert!(delivered_messages.contains_message(100));
assert!(delivered_messages.contains_message(150));
assert!(!delivered_messages.contains_message(151));

assert_eq!(delivered_messages.message_dispatch_result(125), true);
assert!(delivered_messages.message_dispatch_result(125));
}
}