Skip to content

Token-swap-over-bridge pallet #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svyatonik merged 13 commits into from
Aug 2, 2021
Merged

Token-swap-over-bridge pallet #944

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
489b8ea
token swap pallet
svyatonik Apr 28, 2021
6f4a9bc
token swap type (replay protection)
svyatonik May 13, 2021
5cd1b54
post-merge fixes
svyatonik Jun 21, 2021
ea43759
Merge branch 'master' into token-swap-pallet
svyatonik Jul 19, 2021
1da9403
post-merge fix
svyatonik Jul 19, 2021
06dac9f
Update modules/token-swap/src/lib.rs
svyatonik Jul 29, 2021
2dca550
Update modules/token-swap/src/lib.rs
svyatonik Jul 29, 2021
c968bbd
add missing comment part
svyatonik Jul 29, 2021
704845b
Merge branch 'token-swap-pallet' of https://github.com/paritytech/par…
svyatonik Jul 29, 2021
7d4a56e
Update modules/token-swap/src/lib.rs
svyatonik Jul 29, 2021
9fba1df
starting claim after lock period is over is forbidden
svyatonik Jul 29, 2021
ff5dd8e
Merge branch 'token-swap-pallet' of https://github.com/paritytech/par…
svyatonik Jul 29, 2021
1c58024
move spec_version and weight to arguments
svyatonik Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/token-swap/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ pub mod pallet {
/// `swap.target_balance_at_bridged_chain` is above existential deposit of the Bridged chain;
/// 3) the `target_public_at_bridged_chain` matches the `swap.target_account_at_bridged_chain`;
/// 4) the `bridged_currency_transfer_signature` is valid and generated by the owner of the
/// `target_public_at_bridged_chain` account.
/// `target_public_at_bridged_chain` account (read more about [`CallOrigin::TargetAccount`]).
///
/// Violating rule#1 will lead to losing your `source_balance_at_this_chain` tokens. Violating other
Copy link
Contributor

@tomusdrw tomusdrw Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, AFAICT if the swap is in Failed state you can still cancel it, no? So no funds should be lost.

Copy link
Contributor Author

@svyatonik svyatonik Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've signed any call that has succeeded at the target chain (e.g. system::remark), you can't cancel it on this chain.

Copy link
Contributor

@tomusdrw tomusdrw Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah, you're right. Actually given we allow arbitrary calls here, I'd suggest having the user provide weight as well. This will enable calling into proxy accounts, mutlisigs, etc. Also one less thing the pallet needs to know about the remote chain.

Copy link
Contributor Author

@svyatonik svyatonik Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I've also moved bridged_chain_spec_version to arguments

/// rules will lead to losing message fees for this and other transactions + losing fees for message
Expand Down