-
Notifications
You must be signed in to change notification settings - Fork 244
Closed
Description
While working on #552 I noticed that we have quite a bit of crates that are not (will not be?) used, e.g.
- transaction-pool (crates.io dependents - 2 vapory crates with < 100 downloads)
doesn't seem to be used here nor in Substrate - is it superseded by sc-transaction-pool? - contract-address (crates.io dependents - none)
newtype aroundethereum_types::Addressand 3 functions which basically do simple buffer concatenation - does it warrant a separate crate or maybe this can be upstreamed intoethereum_types? - trace-time (crates.io dependents - transaction-pool ^0.1 and 4 vapory deps with <100 downloads)
this is a simple drop guard type that calls specificallylog::trace!with a&'static strlabel and calculates elapsed time usingInstant::elapsed- not flexible enough to be used in production and for simple debugging it's better to just roll your own simple macro/type inline, so that it ties to the existing logging/perf infra.
I don't think we plan to continue using or updating them and if we bump some crates here that these depend on, this introduces busywork like updating relevant changelog or bumping and releasing new versions of these crates (which will probably continue to be unused).
Should we decommission them?
Metadata
Metadata
Assignees
Labels
No labels