parity-util-mem: use ios compilation conditions same as macos. #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Feb 8, 2021
Contributor
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
Thanks!
I don't know which allocator iOS uses by default and whether it's possible to use jemalloc there.
It's fine to merge this if you tested it locally, however it would be hard for us to support iOS w/o proper CI setup for it.
Contributor
niklasad1
approved these changes
Feb 8, 2021
Contributor
Author
|
I guess I have to fix the formatting, I will push it asap. |
cheme
approved these changes
Feb 8, 2021
Collaborator
cheme
left a comment
cheme
left a comment
There was a problem hiding this comment.
LGTM, the cfg default to estimate heap size when we do not use jemalloc (so for mac and ios only option is jemalloc now, not sure if other allocator could make sense for those targets).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #521