This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Improve handle_dependents_after_merge #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoroughly comment handle_dependents_after_merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled to explain what
handle_dependents_after_mergedoes on a meeting with @koenw so, inspired by the documentation effort at #362, this PR thoroughly comments it (not that explaining what it does makes the process less inherently complicated...). While I was commenting on what happens I detected one missing scenario of dangling references (which don't happen very often, but it's still relevant to recognize it), thus this PR takes that into account with a proposed fix.