Skip to content

Move MaxEncodedLen from Substrate #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coriolinus merged 16 commits into from
Jun 23, 2021
Merged

Move MaxEncodedLen from Substrate #268

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
98943ed
move MaxEncodedLen trait from Substrate
coriolinus May 10, 2021
f665e41
Move derive macro and tests from Substrate
coriolinus May 10, 2021
17eda6d
only run ui tests when derive feature enabled
coriolinus May 10, 2021
24b4680
reduce note-taking documentation
coriolinus May 14, 2021
7010204
Merge branch 'master' into prgn-max-encoded-len
Xanewok Jun 21, 2021
6bc8904
Bless trybuild `tests/max_encoded_len_ui/union.rs` test
Xanewok Jun 21, 2021
b79e84a
Update docs (these files are not part of substrate)
coriolinus Jun 21, 2021
7a465d5
Mention new `MaxEncodedLen` trait in the CHANGELOG.md
Xanewok Jun 21, 2021
ccfa540
Prepare a 2.2.0-rc.1 release
Xanewok Jun 21, 2021
9f24e9d
incorporate changes made to Substrate version of MaxEncodedLen
coriolinus Jun 22, 2021
67474db
remove redundant no_std
coriolinus Jun 22, 2021
395dbaa
Rewrite fn max_encoded_len_trait for clarity
coriolinus Jun 22, 2021
7f2db6a
simplify logic checking for invalid attr
coriolinus Jun 23, 2021
39e542a
remove bogus whitespace
coriolinus Jun 23, 2021
5189f84
use Path::is_ident() helper
coriolinus Jun 23, 2021
04b3ad3
rm unused import
coriolinus Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use Path::is_ident() helper 
Co-authored-by: Bastian Köcher <[email protected]>
  • Loading branch information
@coriolinus @bkchr
coriolinus and bkchr authored Jun 23, 2021
commit 5189f843e32d0b760c2b5cf5e0437f5b7459c141
4 changes: 2 additions & 2 deletions derive/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ fn crate_access() -> syn::Result<Ident> {
/// Match `#[codec(crate = ...)]` and return the `...`
fn codec_crate_path_lit(attr: &Attribute) -> Option<Lit> {
// match `#[codec ...]`
if attr.path != parse_quote!(codec) {
if !attr.path.is_ident("codec") {
return None;
};
// match `#[codec(crate = ...)]` and return the `...`
match attr.parse_meta() {
Ok(Meta::NameValue(MetaNameValue { path, lit, .. })) if path == parse_quote!(crate) => {
Ok(Meta::NameValue(MetaNameValue { path, lit, .. })) if path.is_ident("crate") => {
Some(lit)
}
_ => None,
Expand Down