Support custom trait bounds on MaxEncodedLen derive macro #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coriolinus
approved these changes
Jun 25, 2021
Contributor
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Looks good! I particularly like the unit test you wrote. Added some comments which you may choose to address, but none of them are entirely within the scope of this PR, so it's legitimate if you choose not to.
| // https://github.com/paritytech/parity-scale-codec/ | ||
| // blob/f0341dabb01aa9ff0548558abb6dcc5c31c669a1/derive/src/encode.rs#L290-L293 | ||
| syn::Error::new(data.union_token.span(), "Union types are not supported") | ||
| syn::Error::new(data.union_token.span(), "Union types are not supported.") |
Contributor
There was a problem hiding this comment.
This change is going to require downstream changes to a lot of UI tests. It may well be worth doing anyway, but be prepared to follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in paritytech/substrate#9180.