Skip to content

Conversation

@pmikolajczyk41
Copy link
Contributor

The Friday release was using bare Ok and assert_eq, which fails when no-implicit-prelude attribute is used. This causes ink master and PRs to fail (use-ink/ink#1830).

This PR fixes it and bumps patch version

@bkchr
Copy link
Member

bkchr commented Jul 3, 2023

Nice ty!

@pmikolajczyk41
Copy link
Contributor Author

@bkchr @koute @ggwpez I wanted to kindly ask if there's a possibility to make a release soon? it's pretty much necessary to continue ink development :)

@bkchr bkchr merged commit a7c0049 into paritytech:master Jul 3, 2023
@pmikolajczyk41 pmikolajczyk41 deleted the pmikolajczyk41/fix-no-implicit-prelude branch July 3, 2023 11:26
@bkchr
Copy link
Member

bkchr commented Jul 3, 2023

@pmikolajczyk41 done

@pmikolajczyk41
Copy link
Contributor Author

@bkchr thank you a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants