Skip to content

Do we have this documented somewhere? #8

@TriplEight

Description

@TriplEight

Is there a source of truth for this job?
I mean, there are jobs: https://github.com/paritytech/substrate/blob/master/.gitlab-ci.yml#L582-L590

.check-dependent-project:          &check-dependent-project
  stage:                           build
  <<:                              *docker-env
  <<:                              *test-refs-no-trigger
  <<:                              *vault-secrets
  script:
    - git clone
        --depth=1
        "--branch=$PIPELINE_SCRIPTS_TAG"
        https://github.com/paritytech/pipeline-scripts
    - ./pipeline-scripts/check_dependent_project.sh
        paritytech
        substrate
        --substrate
        "$DEPENDENT_REPO"
        "$GITHUB_PR_TOKEN"

# Individual jobs are set up for each dependent project so that they can be ran in parallel.
# Arguably we could generate a job for each companion in the PR's description using Gitlab's
# parent-child pipelines but that's more complicated.

check-dependent-polkadot:
  <<: *check-dependent-project
  variables:
    DEPENDENT_REPO: polkadot

check-dependent-cumulus:
  <<: *check-dependent-project
  variables:
    DEPENDENT_REPO: cumulus

and https://github.com/paritytech/polkadot/blob/master/.gitlab-ci.yml#L275-L294

.check-dependent-project:          &check-dependent-project
  stage:                           build
  <<:                              *docker-env
  <<:                              *vault-secrets
  script:
    - git clone
        --depth=1
        "--branch=$PIPELINE_SCRIPTS_TAG"
        https://github.com/paritytech/pipeline-scripts
    - ./pipeline-scripts/check_dependent_project.sh
        paritytech
        polkadot
        --polkadot
        "$DEPENDENT_REPO"
        "$GITHUB_PR_TOKEN"

check-dependent-cumulus:
  <<: *check-dependent-project
  variables:
    DEPENDENT_REPO: cumulus
  1. all jobs are executed regardless of PR mentioning a Companion: #number. It's OK if they would just run to check if there is a companion and exit, why checking if a companion is not mentioned?
  2. why polkadot can have only cumulus companion? And why substrate has both polkadot and cumulus?
  3. what happens if I do a cross-reference like it was here: Update CI image to the latest rustc substrate#10142 and Update CI image to use the latest rustc polkadot#4200 cc Companion script fails if companion pr was merged #7. Or is it enough to have just one companion reference? According to the current CI jobs it doesn't make any sense to refer to substrate companion from polkadot.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions