Work around transitive companions #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overcome the companion build system's shortcomings: #3 (comment)
joao-paulo-parity
force-pushed
the
workaround-transitive-companions
branch
from
864cda9 to
ba07a72
Compare
joao-paulo-parity
requested review from
TriplEight and
paritytech-ci
and removed request for
paritytech-ci
joao-paulo-parity
changed the title
gilescope
approved these changes
Oct 20, 2021
Contributor
gilescope
left a comment
gilescope
left a comment
There was a problem hiding this comment.
Escape hatches are good for now.
TriplEight
approved these changes
Oct 20, 2021
Contributor
TriplEight
left a comment
TriplEight
left a comment
There was a problem hiding this comment.
You realize that this hotfix will bypass the required job as completed and potentially leads to skipping the job in other "inconvenient" cases, right?
Contributor
Author
@TriplEight Of course this solution is sloppy and terrible in general but people are blocked by this right now and we do not have a solution ready (not even work-in-progress either), so it is justified. This kind of thing should be removed as soon as something better comes along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations such as the one described in #3, it might be necessary to skip the companion checks due to shortcomings of the companion build system (#3 (comment)).
Given that PRs are blocked at the moment due to this shortcoming, we should provide a way of bypassing the check until a proper solution can be implemented, meaning this change can and should be removed at some point.
Solution: from now on people will be able to say
skip check-dependent-cumulusor whatever and then the check will be skipped.related to #3