Skip to content

Conversation

@michalkucharczyk
Copy link
Contributor

Following test are green:
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3535001
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3535002
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3535003

but they are actually not executed correctly:

Genesis spec provided does not exist: /home/nonroot/zombie-net/scripts/ci/1693617573/substrate/zombienet/0001-basic-warp-sync/chain-spec.json

This PR should fix this.

@michalkucharczyk michalkucharczyk added the T10-tests This PR/Issue is related to tests. label Sep 2, 2023
@michalkucharczyk michalkucharczyk requested review from a team and pepoviola September 2, 2023 11:12
@skunert
Copy link
Contributor

skunert commented Sep 2, 2023

Nice catch, I think this cumulus test has the same problem: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3536786

@pepoviola
Copy link
Contributor

Nice catch @michalkucharczyk, this should be reported in the next version of zombienet (I will release it asap). @skunert I fixed the cumulus test 👍.

Thanks!

@michalkucharczyk
Copy link
Contributor Author

michalkucharczyk commented Sep 2, 2023

Looks like cumulus/0007-full_node_warp_sync fails now.

The dave node has some error messages:

+ polkadot --chain /cfg/rococo-local.json --name dave --rpc-cors all --unsafe-rpc-external --rpc-methods unsafe -lparachain=debug --sync warp --reserved-only --reserved-nodes /ip4/10.24.254.35/tcp/30333/ws/p2p/12D3KooWQCkBm1BYtkHpocxCwMgR8yjitEeHGx8spzcDLGt2gkBm /ip4/10.24.218.74/tcp/30333/ws/p2p/12D3KooWRkZhiRhsqmrQ28rt73K7V3aCBpqKrLGSXmZ99PTcTZby /ip4/10.24.218.75/tcp/30333/ws/p2p/12D3KooWPKzmmE2uYgF3z13xjpbFTp63g9dZFag8pG6MgnpSLF4S --no-mdns --node-key 61ea0803f8853523b777d414ace3130cd4d3f92de2cd7ff8695c337d79c2eeee --no-telemetry --prometheus-external --validator --bootnodes /ip4/10.24.254.35/tcp/30333/ws/p2p/12D3KooWQCkBm1BYtkHpocxCwMgR8yjitEeHGx8spzcDLGt2gkBm --prometheus-port 9615 --rpc-port 9944 --listen-addr /ip4/0.0.0.0/tcp/30333/ws --base-path /data
+ read line
Error: 
   0: �[91mOther: Warp sync not supported for validator nodes running BEEFY.�[0m

Is that expected?
Should we allow test to fail and merge this PR?

@pepoviola
Copy link
Contributor

pepoviola commented Sep 2, 2023

Looks like cumulus/0007-full_node_warp_sync fails now.

The dave node has some error messages:

+ polkadot --chain /cfg/rococo-local.json --name dave --rpc-cors all --unsafe-rpc-external --rpc-methods unsafe -lparachain=debug --sync warp --reserved-only --reserved-nodes /ip4/10.24.254.35/tcp/30333/ws/p2p/12D3KooWQCkBm1BYtkHpocxCwMgR8yjitEeHGx8spzcDLGt2gkBm /ip4/10.24.218.74/tcp/30333/ws/p2p/12D3KooWRkZhiRhsqmrQ28rt73K7V3aCBpqKrLGSXmZ99PTcTZby /ip4/10.24.218.75/tcp/30333/ws/p2p/12D3KooWPKzmmE2uYgF3z13xjpbFTp63g9dZFag8pG6MgnpSLF4S --no-mdns --node-key 61ea0803f8853523b777d414ace3130cd4d3f92de2cd7ff8695c337d79c2eeee --no-telemetry --prometheus-external --validator --bootnodes /ip4/10.24.254.35/tcp/30333/ws/p2p/12D3KooWQCkBm1BYtkHpocxCwMgR8yjitEeHGx8spzcDLGt2gkBm --prometheus-port 9615 --rpc-port 9944 --listen-addr /ip4/0.0.0.0/tcp/30333/ws --base-path /data
+ read line
Error: 
   0: �[91mOther: Warp sync not supported for validator nodes running BEEFY.�[0m

Is that expected? Should we allow test to fail and merge this PR?

I think we should pass --no-beefy, since this error is related to this change 89fd980#diff-67483124e887614f5d8edc2a46dd5329354bc294ed58bc1748f41dfeb6ec2404


Update
I just add the flag and now the test is green (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3539269)

@michalkucharczyk
Copy link
Contributor Author

bot merge

@command-bot
Copy link

command-bot bot commented Sep 2, 2023

@michalkucharczyk Unknown command "merge". Refer to help docs and/or source code.

@michalkucharczyk michalkucharczyk merged commit 2c3e869 into master Sep 2, 2023
@michalkucharczyk michalkucharczyk deleted the mku-chainspec-paths-in-zombinet-fixed branch September 2, 2023 19:25
ordian added a commit that referenced this pull request Sep 7, 2023
* master: (25 commits)
  Markdown linter (#1309)
  Update `fmt` file and some authors (#1379)
  Bump the known_good_semver group with 1 update (#1375)
  Bump proc-macro-warning from 0.4.1 to 0.4.2 (#1376)
  feat: add futures api to `TransactionPool` (#1348)
  Ensure cumulus/bridges is ignored by formatter and run it (#1369)
  substrate: chain-spec paths corrected in zombienet tests (#1362)
  contracts: Update to wasmi 0.31 (#1350)
  [improve docs]: Template pallet (#1280)
  [xcm-emulator] Unignore cumulus integration tests (#1247)
  Fix wrong ref counting (#1358)
  Use cached session index to obtain executor params (#1190)
  fix typos (#1339)
  Use bandersnatch-vrfs with locked dependencies ref (#1342)
  Bump bs58 from 0.4.0 to 0.5.0 (#1293)
  Contracts: `seal0::balance` should return the free balance (#1254)
  Logs: add extra debug log for negative rep changes (#1205)
  Added short-benchmarks for cumulus (#1183)
  [xcm-emulator] Improve hygiene and clean up (#1301)
  Bump the known_good_semver group with 1 update (#1347)
  ...
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
* substrate: chain-spec paths corrected in zombienet tests

* fix chain-spec path in cumulus test

* disable beefy on validator

---------

Co-authored-by: Javier Viola <[email protected]>
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* substrate: chain-spec paths corrected in zombienet tests

* fix chain-spec path in cumulus test

* disable beefy on validator

---------

Co-authored-by: Javier Viola <[email protected]>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
…1362)

* substrate: chain-spec paths corrected in zombienet tests

* fix chain-spec path in cumulus test

* disable beefy on validator

---------

Co-authored-by: Javier Viola <[email protected]>
bkchr pushed a commit that referenced this pull request Apr 10, 2024
* fix typos

* clippy fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T10-tests This PR/Issue is related to tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants