assert to ensure in migration post-upgrade

Signed-off-by: muraca <[email protected]>

substrate/frame/assets/src/migration/v2.rs

@@ -137,12 +137,12 @@ impl<T: Config<I>, I: 'static, A: Get<Vec<(T::AssetId, T::AccountId)>>> OnRuntim
 		let mut old_assets: Vec<(
 			T::AssetId,
 			old::AssetDetails<T::Balance, T::AccountId, DepositBalanceOf<T, I>>,
-		)> = Decode::decode(&mut old_status.as_slice())
-			.expect("the state parameter should be something that was generated by pre_upgrade");
+		)> = Decode::decode(&mut old_status.as_slice()).map_err(|_| {
+			"the state parameter should be something that was generated by pre_upgrade"
+		})?;
 
-		assert_eq!(
-			old_assets.len(),
-			Asset::<T, I>::iter().count(),
+		ensure!(
+			old_assets.len() == Asset::<T, I>::iter().count(),
 			"the number of assets should be the same"
 		);
 
@@ -168,7 +168,10 @@ impl<T: Config<I>, I: 'static, A: Get<Vec<(T::AssetId, T::AccountId)>>> OnRuntim
 				.map(|(_, b)| *b)
 				.unwrap_or_else(|| Zero::zero());
 			asset.inactive = inactive;
-			assert_eq!(Asset::<T, I>::get(&asset_id), Some(asset));
+			ensure!(
+				Asset::<T, I>::get(&asset_id) == Some(asset),
+				"migrated asset does not match expected inactive value"
+			);
 		}
 
 		Ok(())