-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Beefy client generic on aduthority Id #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serban300
merged 94 commits into
paritytech:master
from
w3f:skalman--beefy-client-generic-on-auth-id
May 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
5d3dce1
First definition for pair public keys
drskalman be890d4
Two example of implementation of pair for demonestration
drskalman fb6a018
- implement paired crypto `Public` as tuple of two `Public`s - unsuce…
drskalman 62ef8b1
keep both public key object and their continous serialization in pair…
drskalman 8d4e523
implement PassBy and From<Pair> for paired_crypto
drskalman eea74e2
implement rest of aux traits for `paired_crypto::Public` implement so…
drskalman f407d87
Attempt to implement trait `Pair` for `pair_cyrpto::Pair`
drskalman 2606cc4
- Implement trait `Pair` for `paired_crypto::Pair` - Implement a pair…
drskalman 00933da
implement sgin and verify for
drskalman e7719ab
Actually implementing `paired_crypto::{Pair, Public, Signatrue}` for …
drskalman 7a9b677
Implement and pass all test for `paired_crypto`
drskalman a01a814
- move to signle seed for both schemes in `primitives/core/src/paired…
drskalman 7c02658
replace `hex!` → `array_bytes::hex2xx`
drskalman 7f8d958
Apply suggestions from `paired_crypto` code review on type nam, hash …
drskalman eef2cec
Do not panic in `paired::Signature::try_from`
drskalman efb215f
Remove `DoublePair` trait.
drskalman 65584bd
Do not empty implement `paired::Pair`
drskalman e047f75
Use `paired_crypto::Seed` instead of `[u8; SECURE_SEED_LEN]`
drskalman c12b82e
use `ecdsa::PUBLIC_KEY_SERIALIZED_SIZE` and `ecdsa::SIGNATURE_SERIALI…
drskalman dba854a
Remove `paired::DoublePair` impl as well
drskalman 5182c86
- Implement `BytesArray` for both ecdsa and bls Signatures
drskalman 17d0077
Implement encode_and_decode_(public_key/signature)_works test for pai…
drskalman a740589
cargo fmt
drskalman 79f25e9
- Implement RuntimeAppCrypto and necessery hostApi for ecdsa_bls377 c…
drskalman 489522f
cargo fmt
drskalman 05e08b3
make BEEFY Keystore and Worker generic over AuthorityId
drskalman 0541cb0
Fix `BeefyAuthorityId::verify` for `ecdsa_bls_crypto` not to use `ecd…
drskalman 099b86d
Fix comment in `primitives/consensus/beefy/src/lib.rs`
drskalman 033ff57
- implement `sign/verify_with_hasher` for `ecdsa_bls377` `Pair` with …
drskalman 76831b7
Fix typos and improve comment quality
drskalman a0c6d83
Add ecdsa_bls377_sign_with_keccak256 to the keystore
drskalman 102ad62
add and implement `ecdsa_bls377_sign_with_keccak256`
drskalman 25d1afc
- Make BEEFY Keyring to be generic over `AuthorityId`.
drskalman 05a3ebd
Merge remote-tracking branch 'origin/master' into skalman--beefy-clie…
drskalman c860dd0
Improve documention and comments
drskalman 8958fde
Remove unused SimpleKeyPair Trait
drskalman 5ef71c8
Merge branch 'skalman--fix-ecdsa-bls-verify-in-beefy-primitives' of h…
drskalman 3b8eded
add reasoning on why in BEEFY we want the ECDSA signature on Keccak …
drskalman efb350d
Merge branch 'master' into skalman--fix-ecdsa-bls-verify-in-beefy-pri…
drskalman 8cfccd8
fmt
drskalman a15a60d
Improve documentation
drskalman 85f8999
Merge branch 'master' into skalman--beefy-client-keystore-supporting-…
drskalman 9667c1b
Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an…
drskalman b18e2f4
Merge branch 'skalman--fix-ecdsa-bls-verify-in-beefy-primitives' into…
drskalman 00b62ef
fmt
drskalman 3ef0f65
Improve comment quality
drskalman a80264c
Merge branch 'master' into skalman--beefy-client-keystore-supporting-…
drskalman 3f8d533
drop 'perhaps' from generate_with_phrase_should_be_recoverable_with_f…
drskalman 1b48d48
Merge remote-tracking branch 'origin/master' into skalman--beefy-clie…
Lederstrumpf 5f09d22
fmt
Lederstrumpf b04880d
Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an…
drskalman 6304d1e
Apply suggestions from code review
drskalman 7fc1326
Apply suggestions from code review
drskalman 6401a97
use std instead of sp_std as we are not in the Runtime
drskalman 425c3d3
remove sp-std fro Cargo.lock
drskalman e98945f
Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an…
drskalman 59a4b5f
Do not re-export internal of primitives/consensus/beefy/src/test_utils
drskalman f2956c0
fix wrong doc for `BeefySignerAuthority::sign_with_hasher`
drskalman 3422057
Make BEEFY Keyring itself generic over AuthId using PhantomData.
drskalman 7454b6d
Compatiblize all client/beefy tests to Keyring<AuthorityId> enum model
drskalman e0c57b6
Merge branch 'skalman--beefy-client-keystore-supporting-both-ecdsa-an…
drskalman 7718444
Merge branch 'master' into skalman--beefy-client-generic-on-auth-id
drskalman ce9ec49
Fix compile errors after merge with master
drskalman db4ee57
Resolve all errors in BEEFY client test and pass them.
drskalman d230d74
Resolve warning in BEEFY client
drskalman 4464c38
Remove redundant imports
drskalman df03389
Merge remote-tracking branch 'origin/master' into skalman--beefy-clie…
drskalman b82aaa1
fix error in beefy generic client after merge
drskalman 906b436
Remove unused uses
drskalman b8be941
Merge branch 'master' into skalman--beefy-client-generic-on-auth-id
drskalman 3067351
fmt
drskalman b2f7c95
Make BEEFY RPC generic over AuthorityId
drskalman 90cb62e
Don't put `authority_id_works_for_ecdsa` behind bls feature.
drskalman b91af5b
Remove extrac copy of `ecdsa_bls377_sign_with_keccak_works`
drskalman c0fb32a
Adrian really doesn't like semi-colon at the end of a return statement.
drskalman a1d50ec
Remove redundant dead stuff
drskalman 45f9c39
delete the a accidental file
drskalman f7c8b61
Remove SmartDefault
drskalman adfb1bd
Typos and Redudnacies
drskalman 56e75eb
Remove redundant bound from AuthorityIdBound.
drskalman 3969528
fmt
drskalman f75e3a2
warn if backend contains a BEEFY state of an obsolete version
drskalman 5d2f33a
Removing constrain on `<AuthorityId as RuntimeAppPublic>::Signature`
drskalman 6031199
Merge branch 'master' into skalman--beefy-client-generic-on-auth-id-m…
drskalman f55e92f
fix beefy tests after merging
drskalman 99ab160
unwrap beefy justification to pass test
drskalman 8bf7a40
Remove all remaining `<AuthorityId as RuntimeAppPublic>::Signature:
drskalman 7c42d8b
Do `cargo +nightly fmt`
drskalman a326523
Remove redundant imports resolve all warnings
drskalman 725fc2c
make @davxy happy
drskalman d834a1d
Remove empty line from substrate/primitives/consensus/beefy/src/lib.rs
drskalman f65096e
add beefy_primitisto cli/service
drskalman cfc59ed
fmt
drskalman a6a1f82
Merge remote-tracking branch 'origin/master' into skalman--beefy-clie…
drskalman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cargo fmt
- Loading branch information
commit 489522f888e023ebdb72cd1f6b1f0bc8f379e0bd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.