make pruning explicit

polkadot/node/core/pvf/src/artifacts.rs

@@ -180,11 +180,16 @@ pub struct Artifacts {
 }
 
 impl Artifacts {
+	#[cfg(test)]
+	pub(crate) fn new() -> Self {
+		Self { artifacts: HashMap::new() }
+	}
+
 	/// Initialize a blank cache at the given path. This will clear everything present at the
 	/// given path, to be populated over time.
 	///
 	/// The recognized artifacts will be filled in the table and unrecognized will be removed.
-	pub async fn new(cache_path: &Path) -> Self {
+	pub async fn new_and_prune(cache_path: &Path) -> Self {
 		// First delete the entire cache. This includes artifacts and any leftover worker dirs (see
 		// [`WorkerDir`]). Nodes are long-running so this should populate shortly.
 		let _ = tokio::fs::remove_dir_all(cache_path).await;
@@ -194,11 +199,6 @@ impl Artifacts {
 		Self { artifacts: HashMap::new() }
 	}
 
-	#[cfg(test)]
-	pub(crate) fn empty() -> Self {
-		Self { artifacts: HashMap::new() }
-	}
-
 	/// Returns the state of the given artifact by its ID.
 	pub fn artifact_state_mut(&mut self, artifact_id: &ArtifactId) -> Option<&mut ArtifactState> {
 		self.artifacts.get_mut(artifact_id)
@@ -334,7 +334,7 @@ mod tests {
 		// this should remove it and re-create.
 
 		let p = &fake_cache_path;
-		Artifacts::new(p).await;
+		Artifacts::new_and_prune(p).await;
 
 		assert_eq!(std::fs::read_dir(&fake_cache_path).unwrap().count(), 0);
 

polkadot/node/core/pvf/src/host.rs

@@ -247,7 +247,7 @@ pub fn start(config: Config, metrics: Metrics) -> (ValidationHost, impl Future<O
 	let run_sweeper = sweeper_task(to_sweeper_rx);
 
 	let run_host = async move {
-		let artifacts = Artifacts::new(&config.cache_path).await;
+		let artifacts = Artifacts::new_and_prune(&config.cache_path).await;
 
 		run(Inner {
 			cache_path: config.cache_path,
@@ -1028,7 +1028,7 @@ pub(crate) mod tests {
 				cleanup_pulse_interval: Duration::from_secs(3600),
 				artifact_ttl: Duration::from_secs(3600),
 
-				artifacts: Artifacts::empty(),
+				artifacts: Artifacts::new(),
 			}
 		}