Skip to content

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Dec 24, 2023

This splits cumulus-primitives-parachain-inherent into two crates, the previous cumulus-primitives-parachain-inherent and a new cumulus-client-parachain-inherent. The idea behind this is to move the create_at logic into the client crate. This removes quite a lot of unrelated dependencies from the runtime std build and thus, makes the compilation faster. On my Laptop the compilation is goes down by one minute for asset-hub-rococo-runtime. I also assume that the full build of the entire workspace probably can be speed-up a little bit, because more stuff can be compiled in parallel.

@bkchr bkchr added the T9-cumulus This PR/Issue is related to cumulus. label Dec 24, 2023
@bkchr
Copy link
Member Author

bkchr commented Dec 24, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 24, 2023

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4801943 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-e2bc0d33-7e24-4c48-8452-f060a66d5244 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 24, 2023

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4801943 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4801943/artifacts/download.

@bkchr bkchr requested a review from a team January 4, 2024 08:30
@michalkucharczyk michalkucharczyk requested a review from a team January 4, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T9-cumulus This PR/Issue is related to cumulus.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants