Skip to content

Conversation

@xermicus
Copy link
Member

Can this API be marked stable? Implemented in solang here

Signed-off-by: Cyrill Leutwiler <[email protected]>
@xermicus xermicus requested a review from pgherveou January 31, 2024 10:08
@xermicus xermicus requested a review from athei as a code owner January 31, 2024 10:08
Signed-off-by: Cyrill Leutwiler <[email protected]>
@xermicus xermicus added the T7-smart_contracts This PR/Issue is related to smart contracts. label Jan 31, 2024
Signed-off-by: Cyrill Leutwiler <[email protected]>
Copy link
Contributor

@pgherveou pgherveou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be added to ink! integration tests first

Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO an integration test in solang is fine, too. We were just saying we need an integration test in ink! because we just assumed they would implement it first. If it works for Solidity it should definitely work for ink!. That said, if it were a more complex function (like XCM) we would probably want both implementations.

@pgherveou
Copy link
Contributor

IMHO an integration test in solang is fine, too. We were just saying we need an integration test in ink! because we just assumed they would implement it first. If it works for Solidity it should definitely work for ink!. That said, if it were a more complex function (like XCM) we would probably want both implementations.

@xermicus maybe add a ticket to add a Test for the ink! team so we don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants