Contracts: Remove unstable on lock/unlock_delegate_dependency host fns #3606
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
approved these changes
Mar 7, 2024
Contributor
cmichi
left a comment
cmichi
left a comment
There was a problem hiding this comment.
Is anything needed for prdoc?
pgherveou
added
the
T7-smart_contracts
Contributor
Author
|
@ParityReleases Any chance we can push this to v1.8.0, this was an oversight from this PR #3384 that went trhough in this release |
pgherveou
changed the title
xermicus
approved these changes
Mar 7, 2024
smiasojed
approved these changes
Mar 7, 2024
athei
approved these changes
Mar 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Member
|
Sorry was my miss click. |
athei
deleted the
pg/remove-unstable-on-lock-unlock_delegate_dependency-host-fns
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
ApiVersion should have been bumped with #3606 this does that and add a test so we don't forget to do that everytime
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
paritytech#3606) Oversight from PR paritytech#3384. These 2 functions should have been tagged as stable
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
ApiVersion should have been bumped with paritytech#3606 this does that and add a test so we don't forget to do that everytime
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight from PR #3384.
These 2 functions should have been tagged as stable