pallet-xcm: fix weights for all XTs and deprecate unlimited weight ones

[acatangiu]

Fix "double-weights" for extrinsics, use only the ones benchmarked in the runtime.

Deprecate extrinsics that don't specify WeightLimit, remove their usage across the repo.

[acatangiu]

bot bench cumulus-assets --runtime asset-hub-westend --pallet pallet_xcm

[command-bot]

@acatangiu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5719983 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-1f992745-2c6f-48c0-92a9-084451f52915 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@acatangiu Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5719983 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5719983/artifacts/download.

[svyatonik]

Why pallet::weight attribute is removed at all from most of calls. Does it mean that the weight is now zero => near to zero fee + ability to create overweight block. I'm probably missing something important, just caught my eye

[acatangiu]

Why pallet::weight attribute is removed at all from most of calls. Does it mean that the weight is now zero => near to zero fee + ability to create overweight block. I'm probably missing something important, just caught my eye

It is replaced by ::WeightInfo here. The default weight fn is fn with same name in <T as Config>::WeightInfo.

There are some places where I kept pallet::weight because it is non-default (e.g. see execute and execute_blob).

[svyatonik]

Ok, cool stuff! Didn't knew we can do weight definitions in the #[pallet::call(..)]