-
Notifications
You must be signed in to change notification settings - Fork 1.1k
prospective-parachains rework #4035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alindima
merged 67 commits into
master
from
alindima/prospective-parachains-unconnected
May 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
0ce57cf
unify and simplify IntroduceCandidate and CandidateSeconded
alindima 051fbe6
WIP
alindima d6f978d
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 0fe5e34
more code
alindima eb3b252
add a fix and some debug logs
alindima e731bdb
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima b402936
add proper fork and cycle check
alindima 57bf39e
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 36ba647
test out of order manifests
sandreim b0a8437
rename fragment trees to fragment chains
alindima ea08d35
debugging
alindima 5086f3d
fixes
alindima 7ac60d3
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 0d0a601
comment out rococo claimqueue runtime API
alindima de63e08
simplify GetHypotheticalMembership
alindima 8b4d57c
refactoring
alindima 5c9e3cd
more refactoring
alindima 575e3f7
some more refactoring
alindima 8fbe25b
update some comments
alindima a6ea197
re-enable claimqueue on rococo
alindima 83ef424
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 1505f0f
start updating some doc comments
alindima 2c3968b
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 638d8c4
remove blocked advertisement handling
alindima 87a1cdc
update some more comments
alindima d1321b2
fix statement-distribution tests
alindima 07ee903
fix backing and collator-protocol tests
alindima 597a801
fix and comment some prospective-parachains test
alindima eae5f1e
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 83c2100
move fragment_chain to its own folder and start fixing tests
alindima 9f8489d
more tests
alindima 55ec208
even more tests
alindima 05131f3
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 1bd5b14
fix subsystem tests
alindima 71d8a8d
remove fragment_tree folder
alindima c1e0665
finish up fragment_chain unit tests
alindima fa68891
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 420744e
replace Cow over commitments with Arc over entire ProspectiveCandidate
alindima 3fa16ef
some review comments
alindima 1e3c48a
unify HypotheticalCandidate definitions
alindima 89281ea
if we've only one slot to fill in a chain, only accept a connected ca…
alindima 3824e15
fix some subsystem tests
alindima 9b32504
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 4b2ca0f
more hypothetical membership tests
alindima 58e0f6b
fix bug and add more introduce_seconded_candidate tests
alindima b8d3ee8
remove useless result
alindima 9d43bd1
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 4ef3f45
add prdoc
alindima 6b36e71
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 1fa3460
some nits
alindima ce12e12
allow retrying seconding requests if the parent head data is unknown
alindima d4beafb
clippy
alindima 1432ed8
add test for blocking collations from seconding
alindima 6c4fdc0
correct meaning of is_fork_or_cycle
alindima bf919b6
more clarifications around what a potential candidate is
alindima b27cac0
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 41dd958
remove outdated check and comment
alindima f036806
add some more metrics and tweak some logs
alindima d8822c3
clippy
alindima 49a0274
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima a35fc3a
spawn validaiton task before cpu time monitor
sandreim c8f3acd
Revert "spawn validaiton task before cpu time monitor"
sandreim 85fe3e4
some review comments
alindima d50d7b2
unify metrics
alindima 67ff035
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima 7621912
review comms
alindima 6a7d08a
Merge remote-tracking branch 'origin/master' into alindima/prospectiv…
alindima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add prdoc
- Loading branch information
commit 4ef3f45b3a77e0b4a29fe979c443b347ea88e7f3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| title: "Prospective parachains rework" | ||
|
|
||
| doc: | ||
| - audience: Node Dev | ||
| description: | | ||
| Reworks prospective-parachains so that we allow a number of unconnected candidates (for which we don't yet know | ||
| the parent candidate). Needed for elastic scaling. Also simplifies it to not allow parachain forks and cycles. | ||
|
|
||
| crates: | ||
| - name: polkadot-node-core-prospective-parachains | ||
| bump: major | ||
| - name: polkadot-node-core-backing | ||
| bump: minor | ||
| - name: polkadot-collator-protocol | ||
| bump: minor | ||
| - name: polkadot-statement-distribution | ||
| bump: minor | ||
| - name: polkadot-node-subsystem-types | ||
| bump: major | ||
| - name: polkadot-node-subsystem-util | ||
| bump: major | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd first mention that this fundamentally changes what information the subsystem stores and operates on. From a tree to just a chain and bunch of unconnected candidates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reworked the prdoc, let me know if it sounds better now