-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove pallet::getter usage from authority-discovery pallet
#4091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bkchr
merged 16 commits into
paritytech:master
from
PolkadotDom:dom/remove-getter-pallet-authority-discovery
May 10, 2024
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
77ad69d
Remove getter attribute from authority discovery
PolkadotDom ca39da5
Add prdoc
PolkadotDom 0503d92
Merge remote-tracking branch 'upstream/master' into dom/remove-getter…
PolkadotDom 098c925
Merge branch 'master' into dom/remove-getter-pallet-authority-discovery
PolkadotDom 99572f3
Update pr_4091.prdoc
PolkadotDom 3f9c555
Merge branch 'master' into dom/remove-getter-pallet-authority-discovery
PolkadotDom 06e768a
Merge branch 'master' into dom/remove-getter-pallet-authority-discovery
PolkadotDom e29d3e8
Update pr_4091.prdoc
PolkadotDom 822c7d6
Update pr_4091.prdoc
PolkadotDom 19d6d15
Merge branch 'master' into dom/remove-getter-pallet-authority-discovery
liamaharon 932038d
Bump major
PolkadotDom 9cdb68e
Merge branch 'master' into dom/remove-getter-pallet-authority-discovery
PolkadotDom bf62ebd
Merge branch 'master' into dom/remove-getter-pallet-authority-discovery
liamaharon 4cf41bc
Merge remote-tracking branch 'upstream/master' into dom/remove-getter…
PolkadotDom 013f8df
Update pr_4091.prdoc
PolkadotDom 0090f1f
Merge branch 'master' into dom/remove-getter-pallet-authority-discovery
bkchr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 | ||
| # See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json | ||
|
|
||
| title: Remove `pallet::getter` usage from authority-discovery pallet | ||
|
|
||
| doc: | ||
| - audience: Runtime Dev | ||
| description: | | ||
| This PR removes `pallet::getter`s from `pallet-authority-discovery`. | ||
| The syntax `StorageItem::<T, I>::get()` should be used instead. | ||
|
|
||
| crates: | ||
| - name: pallet-authority-discovery | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.