Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
87be8e5
Introduce network backend agnostic `Multiaddr` & `Multihash` types
dmitry-markin Apr 16, 2024
584038e
Extend substrate's `Multihash`, make substrate's `PeerId` use it
dmitry-markin Apr 19, 2024
8100f7f
Allow constructing `Multiaddr` from iterator of protocols
dmitry-markin Apr 19, 2024
ea85860
Convert network config to use substrate's `Multiaddr`
dmitry-markin Apr 19, 2024
94af781
Add `ed25519` types to `sc-network-types`
dmitry-markin Apr 23, 2024
aa4d28d
cargo update litep2p
dmitry-markin Apr 23, 2024
da59b29
Make `Check licenses` check happy
dmitry-markin Apr 24, 2024
f614106
Make network config use substrate-specific types
dmitry-markin Apr 24, 2024
ce321a9
Convert substrate-specific types for libp2p backend
dmitry-markin Apr 24, 2024
a0373ae
Convert substrate-specific types for litep2p backend
dmitry-markin Apr 24, 2024
2bb5448
Cleaner separation between backend-specific types
dmitry-markin Apr 24, 2024
bd7df2e
Make authority-discovery use substrate-specific types
dmitry-markin Apr 24, 2024
7c29f74
Make telemetry use libp2p-only `Multiaddr`
dmitry-markin May 16, 2024
2162dac
Make `cli` use `sc_network::config::ed25519`
dmitry-markin May 16, 2024
bb6f58f
Make authority-discovery tests use proper types
dmitry-markin May 16, 2024
9fc3f80
Fix tests
dmitry-markin May 16, 2024
04a4096
Merge remote-tracking branch 'origin/master' into dm-network-types-mu…
dmitry-markin May 16, 2024
036aac7
Make clippy happy
dmitry-markin May 17, 2024
685de87
Add tests for ed25519 types conversion between libs
dmitry-markin May 17, 2024
dabbd96
Make clippy happy again
dmitry-markin May 17, 2024
a66016c
Add PRDoc
dmitry-markin May 17, 2024
41ffe22
Fix doctest
dmitry-markin May 17, 2024
086f389
Apply review suggestions
dmitry-markin May 20, 2024
7547c49
Update semver in PRDoc
dmitry-markin May 20, 2024
b1bea17
Fix CI
dmitry-markin May 20, 2024
a87a92d
Merge remote-tracking branch 'origin/master' into dm-network-types-mu…
dmitry-markin May 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add PRDoc
  • Loading branch information
dmitry-markin committed May 17, 2024
commit a66016c452e61f2511b842df877052094302ece9
29 changes: 29 additions & 0 deletions prdoc/pr_4198.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Replace `Multiaddr` & related types with substrate-specific types

doc:
- audience: Node Dev
description: |
Introduce custom types / substrate wrappers for `Multiaddr`, `multiaddr::Protocol`,
`Multihash`, `ed25519::*` and supplementary types like errors and iterators.

Common code in substrate uses these custom types, while `libp2p` & `litep2p` network
backends use their corresponding libraries types.

This is needed to independently upgrade `libp2p` & `litep2p` dependencies.

crates:
- name: sc-network-types
bump: minor
- name: sc-network
bump: minor
- name: sc-authority-discovery
bump: patch
- name: sc-cli
bump: patch
- name: sc-mixnet
bump: patch
- name: sc-telemetry
bump: patch