Skip to content

Bring reference_hardware.json inline with machine used for weights #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexggh merged 5 commits into from
Aug 7, 2024
Merged

Bring reference_hardware.json inline with machine used for weights #5196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d11ece
Bring reference_hardware.json inline with machine used for weights
alexggh Jul 31, 2024
a7b019a
Add prdoc
alexggh Jul 31, 2024
347f18b
Update pr_5196.prdoc
alexggh Jul 31, 2024
4c67507
Make the unittests happy
alexggh Jul 31, 2024
2e3ddc3
fixup to values obtained with production profile instead of testnet
alexggh Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions prdoc/pr_5196.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Bring benchmark inline with reference machine used for weights

doc:
- audience: Node Operator
description: |
- BLAKE2-256 reference values were too low(~30%) when compared with the machine used for generating
the weights, so it was brought in sync with results on the reference hardware recommended here:
https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#reference-hardware
- SR25519-Verify reference values were too low(~10%) when compared with the machine used for generating
the weights, so it was brought in sync with results on the reference hardware recommended here:
https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#reference-hardware
- Validators where the `BLAKE2-256` and `SR25519-Verify` were barely passing, might received the
warning that they are not compliant anymore, this should not be treated as critical, but they
should take the necessary steps to become compliant in the near/mid-term future.
- Note!: The reference hardware requirements have not been increased we just fixed the benchmark which
was wrongly reporting lower spec HW as being compliant.

crates:
- name: frame-benchmarking-cli
bump: minor
4 changes: 2 additions & 2 deletions substrate/utils/frame/benchmarking-cli/src/machine/hardware.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ mod tests {
assert_eq!(
*SUBSTRATE_REFERENCE_HARDWARE,
Requirements(vec![
Requirement { metric: Metric::Blake2256, minimum: Throughput::from_mibs(783.27) },
Requirement { metric: Metric::Blake2256, minimum: Throughput::from_mibs(1000.00) },
Requirement {
metric: Metric::Sr25519Verify,
minimum: Throughput::from_kibs(560.670000128),
minimum: Throughput::from_kibs(637.619999744),
},
Requirement {
metric: Metric::MemCopy,
Expand Down
4 changes: 2 additions & 2 deletions substrate/utils/frame/benchmarking-cli/src/machine/reference_hardware.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
[
{
"metric": "Blake2256",
"minimum": 783.27
"minimum": 1000.00
},
{
"metric": "Sr25519Verify",
"minimum": 0.547529297
"minimum": 0.622675781
},
{
"metric": "MemCopy",
Expand Down