Skip to content

xcm: fix local/remote exports when inner routers return NotApplicable #6645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkontur merged 5 commits into from
Nov 26, 2024
Merged

xcm: fix local/remote exports when inner routers return NotApplicable #6645

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
640187e
Fix local/remote exports when inner routers returns `NotApplicable`
bkontur Nov 26, 2024
7a70ab0
Strange "as as" typo
bkontur Nov 26, 2024
566c8a7
Update from bkontur running command 'fmt'
actions-user Nov 26, 2024
5619762
Update from bkontur running command 'prdoc --audience runtime_dev --b…
actions-user Nov 26, 2024
32f5014
Update prdoc/pr_6645.prdoc
bkontur Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update prdoc/pr_6645.prdoc
  • Loading branch information
@bkontur
bkontur authored Nov 26, 2024
commit 32f50149aea647280c7d2898ec641b24c015b2b1
11 changes: 4 additions & 7 deletions prdoc/pr_6645.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,13 @@ title: 'xcm: fix local/remote exports when inner routers return `NotApplicable`'
doc:
- audience: Runtime Dev
description: |-
This PR addresses two small fixes:

1. Fixed a typo ("as as") found on the way.
2. Resolved a bug in the `local/remote exporters` used for bridging. Previously, they consumed `dest` and `msg` without returning them when inner routers/exporters failed with `NotApplicable`. This PR ensures compliance with the [`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450) and [`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45) traits.
Resolved a bug in the `local/remote exporters` used for bridging. Previously, they consumed `dest` and `msg` without returning them when inner routers/exporters failed with `NotApplicable`. This PR ensures compliance with the [`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450) and [`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45) traits.
crates:
- name: staging-xcm-builder
bump: patch
- name: polkadot
bump: patch
bump: none
- name: staging-xcm
bump: patch
bump: none
- name: staging-xcm-executor
bump: patch
bump: none
Loading