Skip to content

Improve set_validation_data error message. #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skunert merged 3 commits into from
Jan 28, 2025
Merged

Improve set_validation_data error message. #7359

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13f1ed9
Clarify missing inherent error message.
skunert Jan 28, 2025
a7994c5
Update from skunert running command 'prdoc --bump patch --audience ru…
github-actions[bot] Jan 28, 2025
4869dd9
Update pr_7359.prdoc
skunert Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cumulus/pallets/parachain-system/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,12 @@ pub mod pallet {
<UpgradeRestrictionSignal<T>>::kill();
let relay_upgrade_go_ahead = <UpgradeGoAhead<T>>::take();

let vfp = <ValidationData<T>>::get()
.expect("set_validation_data inherent needs to be present in every block!");
let vfp = <ValidationData<T>>::get().expect(
r"Missing required set_validation_data inherent. This inherent must be
present in every block. This error typically occurs when the set_validation_data
execution failed and was rejected by the block builder. Check earlier log entries
for the specific cause of the failure.",
);

LastRelayChainBlockNumber::<T>::put(vfp.relay_parent_number);

Expand Down
8 changes: 8 additions & 0 deletions prdoc/pr_7359.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
title: Improve `set_validation_data` error message.
doc:
- audience: Runtime Dev
description: The old error message was often confusing, because the real reason
for the error will be printed during inherent execution.
crates:
- name: cumulus-pallet-parachain-system
bump: patch
Loading