Skip to content

Use checked math in frame-balances named_reserve #7365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 3 commits into from
Jan 29, 2025
Merged

Use checked math in frame-balances named_reserve #7365

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75c8db6
Use checked math in frame-balances named_reserve
cl0w5 Jan 28, 2025
90e30e8
Update from bkchr running command 'prdoc --audience runtime_dev --bum…
github-actions[bot] Jan 28, 2025
f87f762
Update from ggwpez running command 'fmt'
github-actions[bot] Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions substrate/frame/balances/src/impl_currency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,8 +674,7 @@ where
Reserves::<T, I>::try_mutate(who, |reserves| -> DispatchResult {
match reserves.binary_search_by_key(id, |data| data.id) {
Ok(index) => {
// this add can't overflow but just to be defensive.
reserves[index].amount = reserves[index].amount.defensive_saturating_add(value);
reserves[index].amount = reserves[index].amount.checked_add(&value).ok_or(ArithmeticError::Overflow)?;
},
Err(index) => {
reserves
Expand Down
Loading