Skip to content

paras_inherent: fix overweight warn #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ordian merged 2 commits into from
Jun 16, 2025
Merged

paras_inherent: fix overweight warn #8861

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b8535
paras_inherent: fix overweight warn
ordian Jun 16, 2025
2d0b018
move the zeroing to inclusion
ordian Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
move the zeroing to inclusion
  • Loading branch information
@ordian
ordian committed Jun 16, 2025
commit 2d0b018b4952817526ab76bcf695115bba88eaab
8 changes: 6 additions & 2 deletions polkadot/runtime/parachains/src/inclusion/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,8 +615,12 @@ impl<T: Config> Pallet<T> {
}
});
}

(weight, freed_cores)
// For relay chain blocks, we're (ab)using the proof size
// to limit the raw transaction size of `ParaInherent` and
// there's no state proof (aka PoV) associated with it.
// Since we already accounted for bitfields size, we should
// not include `enact_candidate` PoV impact here.
(weight.set_proof_size(0), freed_cores)
}

/// Process candidates that have been backed. Provide a set of
Expand Down
8 changes: 1 addition & 7 deletions polkadot/runtime/parachains/src/paras_inherent/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,13 +511,7 @@ impl<T: Config> Pallet<T> {
&validator_public[..],
bitfields.clone(),
);
// For relay chain blocks, we're (ab)using the proof size
// to limit the raw transaction size of `ParaInherent` and
// there's no state proof (aka PoV) associated with it.
// Since we already accounted for bitfields size, we should
// not include `enact_candidate` PoV impact here.
all_weight_after.saturating_accrue(enact_weight.set_proof_size(0));

all_weight_after.saturating_accrue(enact_weight);
log::debug!(
target: LOG_TARGET,
"Enacting weight: {}, all weight: {}",
Expand Down
Loading