Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add transfer events to CurrencyAdapter? #3508

@apopiak

Description

@apopiak

Functions implemented for Currency do not emit events currently. E.g. deposit_creating here

This makes it difficult to trace transfers when these functions are called e.g. via XCM. (As surfaced by #3489)

Should we address this in the underlying implementation or do we expect the callers to generate the events?
We could adjust the CurrencyAdapter to add events. (Similar question arises for the FungiblesAdapter, of course, though the fungibles implementation in the assets pallet does emit events for mint, burn and transfer.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    I4-annoyanceCode behaves within expectations, however this “expected behaviour” itself is at issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions