This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add the ability to change the informant's prefix #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forked at: 4234dee Parent branch: origin/master
Parent branch: origin/master Forked at: 4234dee
cecton
force-pushed
the
cecton-informant-prefix
branch
from
886054e to
2fd72f7
Compare
bkchr
reviewed
Jun 10, 2020
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
You can not just add "prefix" everywhere as parameter without any documentation
collator/src/lib.rs
Outdated
| para_id: ParaId, | ||
| key: Arc<CollatorPair>, | ||
| config: Configuration, | ||
| prefix: Option<String>, |
Contributor
Author
There was a problem hiding this comment.
I renamed to informant_prefix. I think it's already quite self explanatory. Good?
Parent branch: origin/master Forked at: 4234dee
bkchr
approved these changes
Jun 10, 2020
cecton
added a commit
that referenced
this pull request
Jun 11, 2020
* Initial commit Forked at: 4234dee Parent branch: origin/master * Add the ability to change the informant's prefix * Update Cargo.lock * Update Cargo.lock * fixed tests * Rename prefix to informant prefix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to paritytech/cumulus#19