Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

implement bitfield signing subsystem #1364

Merged
coriolinus merged 17 commits into from
Jul 23, 2020
Merged

implement bitfield signing subsystem #1364

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
170efd3
update guide to reduce confusion and TODOs
coriolinus Jul 6, 2020
ed778a4
work from previous bitfield signing effort
coriolinus Jul 20, 2020
a8d312c
start rewriting bitfield signing in terms of the util module
coriolinus Jul 20, 2020
6d3081a
implement construct_availability_bitvec
coriolinus Jul 21, 2020
29cc1c3
implement the unimplemented portions of bitfield signing
coriolinus Jul 22, 2020
5807799
get core availability concurrently, not sequentially
coriolinus Jul 22, 2020
00ef611
use sp-std instead of std for a parachain item
coriolinus Jul 22, 2020
7fc7780
resolve type inference failure caused by multiple From impls
coriolinus Jul 22, 2020
684038f
handle bitfield signing subsystem & Allmessages variant in overseer
coriolinus Jul 22, 2020
f14ffe5
fix more multi-From inference issues
coriolinus Jul 22, 2020
89ff07b
more concisely handle overflow
coriolinus Jul 22, 2020
51dbee5
Merge remote-tracking branch 'origin/master' into prgn-bitfield-signing
coriolinus Jul 23, 2020
c1b8b54
Revert "resolve type inference failure caused by multiple From impls"
coriolinus Jul 23, 2020
4410c87
Revert "fix more multi-From inference issues"
coriolinus Jul 23, 2020
528cf9b
impl From<i32> for ParaId
coriolinus Jul 23, 2020
7779405
handle another instance of AllSubsystems
coriolinus Jul 23, 2020
333d076
improve consistency when returning existing options
coriolinus Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix more multi-From inference issues
  • Loading branch information
@coriolinus
coriolinus committed Jul 22, 2020
commit f14ffe589e20d664d8a900ed62f68b6fb844a514
6 changes: 3 additions & 3 deletions node/core/backing/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,9 +798,9 @@ mod tests {

impl Default for TestState {
fn default() -> Self {
let chain_a = ParaId::from(1);
let chain_b = ParaId::from(2);
let thread_a = ParaId::from(3);
let chain_a = ParaId::from(1_u32);
let chain_b = ParaId::from(2_u32);
let thread_a = ParaId::from(3_u32);

let chain_ids = vec![chain_a, chain_b, thread_a];

Expand Down
10 changes: 5 additions & 5 deletions node/network/statement-distribution/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,21 +915,21 @@ mod tests {
let candidate_a = {
let mut c = CommittedCandidateReceipt::default();
c.descriptor.relay_parent = parent_hash;
c.descriptor.para_id = 1.into();
c.descriptor.para_id = 1_u32.into();
c
};

let candidate_b = {
let mut c = CommittedCandidateReceipt::default();
c.descriptor.relay_parent = parent_hash;
c.descriptor.para_id = 2.into();
c.descriptor.para_id = 2_u32.into();
c
};

let candidate_c = {
let mut c = CommittedCandidateReceipt::default();
c.descriptor.relay_parent = parent_hash;
c.descriptor.para_id = 3.into();
c.descriptor.para_id = 3_u32.into();
c
};

Expand Down Expand Up @@ -1144,7 +1144,7 @@ mod tests {
let candidate = {
let mut c = CommittedCandidateReceipt::default();
c.descriptor.relay_parent = hash_c;
c.descriptor.para_id = 1.into();
c.descriptor.para_id = 1_u32.into();
c
};
let candidate_hash = candidate.hash();
Expand Down Expand Up @@ -1279,7 +1279,7 @@ mod tests {
let candidate = {
let mut c = CommittedCandidateReceipt::default();
c.descriptor.relay_parent = hash_b;
c.descriptor.para_id = 1.into();
c.descriptor.para_id = 1_u32.into();
c
};

Expand Down