Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Pallet for Purchase #1369

Merged
gavofyork merged 47 commits into from
Jul 17, 2020
Merged

Pallet for Purchase #1369

gavofyork merged 47 commits into from
Jul 17, 2020

Conversation

@shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Jul 7, 2020 •
edited
Loading

In progress

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jul 7, 2020
@shawntabrizi shawntabrizi marked this pull request as draft July 7, 2020 10:50
ngotchac
ngotchac reviewed Jul 7, 2020
View reviewed changes
@shawntabrizi shawntabrizi marked this pull request as ready for review July 8, 2020 17:04
@shawntabrizi shawntabrizi added B2-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Jul 8, 2020
@shawntabrizi shawntabrizi marked this pull request as ready for review July 16, 2020 13:35
@jacogr jacogr mentioned this pull request Jul 16, 2020
Closed
gavofyork
gavofyork reviewed Jul 17, 2020
View reviewed changes
gavofyork
gavofyork reviewed Jul 17, 2020
View reviewed changes
gavofyork
gavofyork reviewed Jul 17, 2020
View reviewed changes
@gavofyork
Copy link
Member

gavofyork commented Jul 17, 2020

Merging #1407 should help with the build.

shawntabrizi
shawntabrizi commented Jul 17, 2020
View reviewed changes
@gavofyork gavofyork merged commit 5b27dd3 into master Jul 17, 2020
@gavofyork gavofyork deleted the shawntabrizi-purchase branch July 17, 2020 12:23
@gavofyork gavofyork added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. labels Sep 8, 2020
@shawntabrizi shawntabrizi mentioned this pull request Sep 27, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ngotchac ngotchac ngotchac left review comments

@gavofyork gavofyork gavofyork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shawntabrizi @gavofyork @ngotchac @paritytech-ci