Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@coriolinus
Copy link
Contributor

Closes #1436.

@coriolinus coriolinus self-assigned this Jul 27, 2020
@rphmeier rphmeier added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 28, 2020
Copy link
Contributor Author

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@montekki Here's the current state of work. The biggest remaining todo, aside from the unimplemented bit and getting answers to all the review questions, will be to write a bunch of tests to verify that this actually works as expected.

Another TODO item I've thought of, but which might be better off as its own issue, will be to abstract away the potential for runtime errors. It's not ideal that the util runtime functions all return Result<RuntimeApiReceiver<T>, Error>. Given that the universal response to a runtime failure appears to be to log the error and then proceed, we could rewrite them to write their own log warning, and return Result<Option<Receiver<T>>, Error>. That TODO might be better extracted to its own issue, though.

@coriolinus
Copy link
Contributor Author

I believe that this now implements the complete candidate selection algorithm from the guide. I'm going to work on adding tests now. I'm not going to mark this as ready for review until the tests are in, but I think it's ready for a preliminary look.

@coriolinus coriolinus marked this pull request as ready for review August 6, 2020 14:50
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 6, 2020
@rphmeier rphmeier merged commit a39d880 into master Aug 6, 2020
@rphmeier rphmeier deleted the prgn-provisioner branch August 6, 2020 16:12
[package]
name = "polkadot"
version = "0.8.22"
version = "0.8.19"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this version revert intentional? probably bad merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was an accident.

ordian added a commit that referenced this pull request Aug 6, 2020
* master:
  implement provisioner (#1473)
  Implementer's guide: downward messages and HRMP, take 2 (#1503)
  Revert "Ignore checks for companion PRs (#1455)" (#1549)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement: Provisioner

4 participants