Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #6825 #1552

Merged
gnunicorn merged 12 commits into from
Sep 17, 2020
Merged

Companion for #6825 #1552

gnunicorn merged 12 commits into from
Sep 17, 2020

Conversation

@sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Aug 7, 2020

@sorpaas sorpaas added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Aug 7, 2020
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 7, 2020
@sorpaas sorpaas added the B0-silent Changes should not be mentioned in any release notes label Aug 7, 2020
@sorpaas sorpaas mentioned this pull request Aug 7, 2020
Merged
@sorpaas sorpaas added the C1-low PR touches the given topic and has a low impact on builders. label Sep 11, 2020
@sorpaas sorpaas requested a review from dvdplm September 11, 2020 13:02
ordian
ordian approved these changes Sep 13, 2020
View reviewed changes
Copy link

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, needs Cargo.lock update.

@ordian ordian added A7-looksgoodcantmerge and removed A0-please_review Pull request needs code review. labels Sep 13, 2020
@gnunicorn gnunicorn merged commit ff1dd3a into master Sep 17, 2020
@gnunicorn gnunicorn deleted the sp-com-6825 branch September 17, 2020 09:04
@gnunicorn gnunicorn mentioned this pull request Sep 17, 2020
Merged
ordian pushed a commit that referenced this pull request Sep 17, 2020
Merge branch 'master' into ao-validator-discovery-api
c03f766 
* master:
  Unbreak master (#1729)
  Skeleton of the Router module (#1726)
  Companion for #6825 (#1552)
  Update Polkadot tokenDecimals & tokenSymbol (#1711)
  Prepare Polkadot to be used by Cumulus (#1697)
  Companion for #7103 (WeightInfo for Vesting) (#1721)
  Implementer's Guide: Router fixes (#1727)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dvdplm dvdplm Awaiting requested review from dvdplm

1 more reviewer

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sorpaas @ordian @gnunicorn @dvdplm