Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@drahnr
Copy link
Contributor

@drahnr drahnr commented Aug 10, 2020

Impl of swapping the para type from thread to chain and vice versa while keeping all modalities.

Ref #1509

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 10, 2020
@drahnr drahnr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes and removed A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Aug 10, 2020
@drahnr drahnr self-assigned this Aug 10, 2020
@drahnr drahnr marked this pull request as draft August 10, 2020 16:10
@drahnr drahnr added C1-low PR touches the given topic and has a low impact on builders. A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 10, 2020
@drahnr drahnr linked an issue Aug 10, 2020 that may be closed by this pull request
@rphmeier
Copy link
Contributor

rphmeier commented Aug 12, 2020

The old behavior was something like this:

Two paras agree to swap. This can be chain<>chain, thread<>thread, or chain<>thread. Practically, we only really need to support the chain<>thread case. Then the swap is carried out: the chains' IDs stay the same, but their kind (thread/chain) are swapped, as well as their deposits.

Looking at this PR, it doesn't seem that this is what it's doing.

@drahnr
Copy link
Contributor Author

drahnr commented Aug 12, 2020

No it doesn't, it was only the very beginning of swapping thread <> chain , but since then, #1559 appeared + assumptions got falsified.

@burdges
Copy link
Contributor

burdges commented Aug 12, 2020

I'd assume the swap only takes effect two epochs later or whatever?

@rphmeier
Copy link
Contributor

@burdges At the end of the current session (epoch) was what I was thinking

@burdges
Copy link
Contributor

burdges commented Aug 12, 2020

It's fine I think. I worried about something that looks not really too problematic anyways.

@drahnr drahnr closed this Aug 20, 2020
@acatangiu acatangiu deleted the bernhard-para-swapping-issue-1509 branch December 12, 2022 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parachain/thread swapping

4 participants