Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Allow using any polkadot client instead of enum Client #1575

Merged
15 commits merged into from
Aug 13, 2020
Merged

Allow using any polkadot client instead of enum Client #1575

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ac4e6c4
WIP
cecton Aug 12, 2020
5527eaa
WIP
cecton Aug 12, 2020
47f184e
WIP
cecton Aug 12, 2020
f60375c
WIP
cecton Aug 12, 2020
99bbf74
WIP
cecton Aug 12, 2020
43512e8
WIP
cecton Aug 12, 2020
ae7082c
WIP
cecton Aug 12, 2020
fb78f0b
WIP
cecton Aug 12, 2020
846e23f
Apply suggestions from code review
cecton Aug 12, 2020
5caaaeb
WIP
cecton Aug 13, 2020
0070028
WIP
cecton Aug 13, 2020
b66861c
WIP
cecton Aug 13, 2020
96cdf51
CLEANUP
cecton Aug 13, 2020
5c4f5ca
link in doc
cecton Aug 13, 2020
12cbf02
doc
cecton Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP 
Forked at: e916423
Parent branch: origin/rococo-branch
  • Loading branch information
@cecton
cecton committed Aug 12, 2020
commit 99bbf74dbee78f65cbb05e34d0315f80b1c4e3f5
3 changes: 1 addition & 2 deletions collator/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,14 @@ pub trait BuildParachainContext {
type ParachainContext: self::ParachainContext;

/// Build the `ParachainContext`.
fn build<SP, Client, Block, Backend>(
fn build<SP, Client, Backend>(
self,
client: Arc<Client>,
spawner: SP,
network: impl Network + SyncOracle + Clone + 'static,
) -> Result<Self::ParachainContext, ()>
where
SP: SpawnNamed + Clone + Send + Sync + 'static,
Block: BlockT,
Backend: BackendT<Block>,
Copy link
Member

@bkchr bkchr Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sooo happy that we got rid off it :P But yeah, this will also make some code easier in Cumulus 👍

Copy link
Contributor Author

@cecton cecton Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I AM SO SORRY

Backend::State: sp_api::StateBackend<BlakeTwo256>,
Client: polkadot_service::AbstractClient<Block, Backend>,
Expand Down
1 change: 1 addition & 0 deletions node/test-service/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ pub struct TestClient(Arc<FullClient<polkadot_test_runtime::RuntimeApi, Polkadot
// TODO: that comes from service, make it public?
type FullBackend = service::TFullBackend<Block>;

// TODO: maybe implementable for any Arc<TFullClient<...>>?
impl YaExecuteWithClient for TestClient {
fn execute_with<T: ExecuteWithClient>(&self, t: T) -> T::Output {
T::execute_with_client::<_, _, FullBackend>(t, self.0.clone())
Expand Down