This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Register listeners in statement distribution #1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
added
A0-please_review
coriolinus
approved these changes
Sep 28, 2020
pepyakin
reviewed
Sep 28, 2020
| ) { | ||
| // Ignore the errors since these will be removed later. | ||
| for listener in listeners.iter_mut() { | ||
| let _ = listener.send(statement.clone()).await; |
Contributor
There was a problem hiding this comment.
a DQ: shouldn't we fan out sending and await the joined future?
Contributor
There was a problem hiding this comment.
Something like futures::stream::iter(listeners.iter_mut()).for_each_concurrent(None, |listener| listener.send(statement.clone()) is probably a good idea. Then again, I have the impression that we're rarely going to have more than a few listeners at a time, so it may not make any practical difference.
pepyakin
reviewed
Sep 28, 2020
| StatementDistributionMessage::Share(relay_parent, statement) => | ||
| StatementDistributionMessage::Share(relay_parent, statement) => { | ||
| inform_statement_listeners( | ||
| statement.clone(), |
Contributor
There was a problem hiding this comment.
If it's cloned inside the function should we pass statement there as a reference to save us one clone?
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1708