This repository was archived by the owner on Nov 15, 2023. It is now read-only.
subsystem: move Metrics to utils #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A2-insubstantial
montekki
approved these changes
Sep 29, 2020
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
pushed a commit
that referenced
this pull request
Oct 6, 2020
* master: Make collation an optional return (#1787) XCM: Land xcm-handler and xcm-executor (#1771) v0.8.25 (#1785) add two node local net script (#1781) Adjust max nominators down to 128 (from 256) (#1782) Companion for substrate/pull/7215 (#1768) Remove Stale Upgrades (#1780) Update Polkadot Weights for Substrate 2.0 (#1761) Parachains v1 registrar module. (#1559) Derive `From` for `AllMessages` and simplify `send_msg` (#1774) implement remaining subsystem metrics (#1770) Companion for paritytech/substrate#7236 (#1773) WIP: remove deprecated only/except clauses, build is now manual on PRs (#1769) Increase Westend `spec_version` (#1766) move Metrics to utils (#1765)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove
Metricsas an associated type fromSubsystemtrait.It was initially added as an assoc type to Metrics for two reasons:
SubsystemName::Metrics::register(registry)But given workarounds like #1741 (comment), it seems better to remove it for now.