address review nits

node/core/candidate-selection/src/lib.rs

@@ -396,14 +396,14 @@ struct MetricsInner {
 pub struct Metrics(Option<MetricsInner>);
 
 impl Metrics {
-	fn on_second(&self, result: core::result::Result<(), ()>) {
+	fn on_second(&self, result: Result<(), ()>) {
 		if let Some(metrics) = &self.0 {
 			let label = if result.is_ok() { "succeeded" } else { "failed" };
 			metrics.seconds.with_label_values(&[label]).inc();
 		}
 	}
 
-	fn on_invalid_selection(&self, result: core::result::Result<(), ()>) {
+	fn on_invalid_selection(&self, result: Result<(), ()>) {
 		if let Some(metrics) = &self.0 {
 			let label = if result.is_ok() { "succeeded" } else { "failed" };
 			metrics.invalid_selections.with_label_values(&[label]).inc();

node/core/provisioner/src/lib.rs

@@ -472,7 +472,7 @@ struct MetricsInner {
 pub struct Metrics(Option<MetricsInner>);
 
 impl Metrics {
-	fn on_inherent_data_request(&self, response: core::result::Result<(), ()>) {
+	fn on_inherent_data_request(&self, response: Result<(), ()>) {
 		if let Some(metrics) = &self.0 {
 			match response {
 				Ok(()) => metrics.inherent_data_requests.with_label_values(&["succeded"]).inc(),

node/overseer/src/lib.rs

@@ -1458,9 +1458,9 @@ mod tests {
 				res = overseer_fut => {
 					assert!(res.is_ok());
 					let metrics = extract_metrics(&registry);
-					assert_eq!(metrics.get("activated").copied().unwrap(), 3);
-					assert_eq!(metrics.get("deactivated").copied().unwrap(), 2);
-					assert_eq!(metrics.get("relayed").copied().unwrap(), 1);
+					assert_eq!(metrics["activated"], 3);
+					assert_eq!(metrics["deactivated"], 2);
+					assert_eq!(metrics["relayed"], 1);
 				},
 				complete => (),
 			}
@@ -1475,7 +1475,6 @@ mod tests {
 		let activated = gather[0].get_metric()[0].get_counter().get_value() as u64;
 		let deactivated = gather[1].get_metric()[0].get_counter().get_value() as u64;
 		let relayed = gather[2].get_metric()[0].get_counter().get_value() as u64;
-
 		let mut result = HashMap::new();
 		result.insert("activated", activated);
 		result.insert("deactivated", deactivated);